Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update libraries-bom in 3.x #3425

Merged
merged 5 commits into from
Dec 19, 2024
Merged

chore: update libraries-bom in 3.x #3425

merged 5 commits into from
Dec 19, 2024

Conversation

JoeWang1127
Copy link
Contributor

No description provided.

@JoeWang1127
Copy link
Contributor Author

Unit test failed:

Error:  Failures: 
Error:    DefaultSubscriberFactoryTests.testCreateSubscriber_validateSetProperties:384 
Expecting
  com.google.cloud.pubsub.v1.Subscriber@56681eaf
to have a property or a field named "maxAckExtensionPeriod" with value
  PT2S
but value was:
  2S
(static and synthetic fields are ignored)

@diegomarquezp
Copy link
Contributor

The test started failing since googleapis/java-pubsub#2271

The test confirms that private fields have a certain value, but these fields were changed to java.time.Duration.

This does not imply any breakage in the public interface of java-pubsub

@diegomarquezp diegomarquezp mentioned this pull request Dec 19, 2024
Merged
@JoeWang1127 JoeWang1127 marked this pull request as ready for review December 19, 2024 20:17
@JoeWang1127 JoeWang1127 merged commit 15ca0dc into 3.x Dec 19, 2024
26 of 27 checks passed
@JoeWang1127 JoeWang1127 deleted the chore/update-libraries-bom-3.x branch December 19, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burkedavison burkedavison burkedavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoeWang1127 @diegomarquezp @burkedavison